Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local directives about background image #4

Merged
merged 5 commits into from
Apr 1, 2018

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 1, 2018

It supports background image by using Marpit's local directives. This way follows reveal.js. A difference is that Marpit must use url() prefix to specify external resource because of using pure CSS style to support linear-gradient(), radial-gradient() and so on.

However, we will not regard that it is the only feature for supporting background image. The pre-released version of Marp have ![bg]() syntax, and Marpit will follow it by adding a markdown-it plugin to convert syntax. We will work about its implementation as soon as finished work about this PR.

ToDo

  • Add tests
  • Update CHANGELOG.md
  • Update ToDo section in README.md

@yhatt yhatt merged commit 09f5428 into master Apr 1, 2018
@yhatt yhatt deleted the background-image-support branch April 1, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant