Use ESLint recommended config instead of eslint-config-airbnb #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marp team had adopted
eslint-config-airbnbas a primary ESLint config. However, it becomes a little obsoleted by evolving Node and JavaScript.So we have determined the change the primary config to
eslint:recommended+plugin:import/recommended. They would reduce stresses when using modern features (e.g. Iterators and generators)A only rule we manually enabled is
import/order. Sometimes I had arranged the import order implicitly, but it's not required effort for us. And now, developer can fix easily to the consistent order, by just runningyarn lint:js --fix.If Marpit's change did work well, we would follow this rule in our related packages (Marp Core, Marp CLI, and so on: Including the work for migration from TSLint to ESLint)