Add feature detection for WebKit #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari is working on the layer-based SVG engine. A polyfill must not apply if the option was enabled.
yhatt
commented
Feb 5, 2023
Comment on lines
+130
to
+133
| // Repaint viewport forcibly when initial observing, to clear buggy SVG debris | ||
| document.body.style['zoom'] = 1.0001 | ||
| void document.body.offsetHeight | ||
| document.body.style['zoom'] = 1 |
There was a problem hiding this comment.
If non-polyfilled SVG had been rendered before applying polyfills, WebKit sometime leaves SVG debris. An updated feature detection is asynchronous so we have to deal with debris.
This snippet triggers repaint in the whole of HTML contents to clear SVG debris in everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit's layer-based SVG engine is the last piece to fix this long-standing bug. If it would be ready, Marpit and related tools finally can make polyfill-free.
I've added a feature detection of WebKit LBSE. If enabled LBSE, marpit-svg-polyfill will never apply even if used WebKit. (In Safari TP, a restart required after toggled LBSE)