Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account a zoom level to scale slide by polyfill #19

Merged
merged 6 commits into from
Mar 22, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Mar 20, 2019

It will fix incorrect scaling of slide by @marp-team/marpit-svg-polyfill, by taking into account VS Code's zoom level.

Current VSCode has a serious rendering bug caused by an old Chromium and we have to apply WebKit Polyfill for scaling. However, it had not considered window's zoom factor. (marp-team/marpit-svg-polyfill#3)

I've updated polyfill that can be considering window zoom scale. (marp-team/marpit-svg-polyfill#4)

Today, it is difficult to detect a zoom factor within browser context. We will read VS Code's window.zoomLevel setting before rendering Markdown and use calculated zoom factor in preview.

Resolve #8.

@yhatt
Copy link
Member Author

yhatt commented Mar 22, 2019

UPDATE: Updated dependent packages to the latest version due to yarn audit that has reported DoS in js-yaml.
https://circleci.com/gh/marp-team/marp-vscode/62

@yhatt yhatt merged commit 7affb11 into master Mar 22, 2019
@yhatt yhatt deleted the fix-incorrect-scaling branch March 22, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preview of slides do not scale properly on linux
1 participant