Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew Docker image to change the base from Alpine to Debian slim, and publish also to GitHub Container Registry #608

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Oct 5, 2024

Marp CLI v4 will introduce brand-new official container image:

  • Revert Dockerfile to build Marp CLI from source in the build phase instead of using already built asset. An original change had been introduced in #402, but using multi-stage build with --platform=$BUILDPLATFORM is much better.
  • Publish the image into both of Docker Hub and GitHub Container Registry. The image publishing workflow has been moved from CircleCI to GitHub Actions, and it will publish the image into marpteam/marp-cli and ghcr.io/marp-team/marp-cli at the same time. Closes #578.
  • The latest state of main branch becomes tagged as main instead of latest from v4. We had treated latest as "the latest including in-development", but it seems to have been actually brought confusion. In v4, latest tag will point the latest release v4.X.X, and in-development latest will become main, same as the branch name.

@yhatt yhatt linked an issue Oct 5, 2024 that may be closed by this pull request
@yhatt yhatt merged commit f9be4ff into main Oct 5, 2024
1 check passed
@yhatt yhatt deleted the new-docker-image branch October 5, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant