Improved WSL 2 detection and browser resolution #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved WSL2 detection by using multiple heuristics.
Marp CLI will find out the browser for PDF/PPTX/image conversion automatically from the host OS (Windows). It works in WSL 1 but Puppeteer in WSL 2 cannot communicate with the browser spawned in the host OS.
I've updated
isWSL()
utility method for more reliable WSL 2 detection. We have no longer resolved Puppeteer from the host OS if WSL 2 was detected.WSL2 detection is based on multiple heuristics on WSL environment:
WSL_DISTRO_NAME
andWSL_INTEROP
environment values./proc/version
is includingMicrosoft-Standard-WSL2
.Related to marp-team/marp#113, and may resolve marp-team/marp#247.