Fix <FilterLiveSearch>
should react to filter values change
#9996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you have both a
<FilterLiveSearch>
and a<FilterButton>
, clicking on 'Remove all filters' in the<FilterButton>
doesn't clear the<FilterLiveSearch>
text input (although the filters are indeed cleared).Similarily, updating the filter value for the field targeted by
<FilterLiveSearch source>
doesn't update the<FilterLiveSearch>
text input (although the filter is applied).Solution
Use
values
instead ofdefaultValues
when declaring the form for<FilterLiveSearch>
, which makes it reactive.How To Test
WithFilterButton
)Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.