Fix DatagridHeader Tooltip when using React element as a field label #9948
+73
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jun 24, 2024
packages/ra-ui-materialui/src/list/datagrid/DatagridHeaderCell.tsx
Outdated
Show resolved
Hide resolved
adguernier
approved these changes
Jun 24, 2024
fzaninotto
requested changes
Jun 24, 2024
packages/ra-ui-materialui/src/list/datagrid/Datagrid.stories.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
approved these changes
Jun 25, 2024
fzaninotto
deleted the
fix-datagrid-headers-when-using-elements-as-field-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using a React element as
labelfor a field, the datagrid header tooltip displaysSort by [object Oject] descending.Solution
Fallback to the default inferred label