create-react-admin gh action to test new apps #9580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
force-pushed
the
create-react-admin-gh-action
branch
from
506fc08 to
7e8acf5
Compare
slax57
requested changes
Jan 23, 2024
packages/create-react-admin/templates/ra-data-fakerest/src/App.spec.tsx
Outdated
Show resolved
Hide resolved
djhi
force-pushed
the
create-react-admin-gh-action
branch
from
d94a314 to
f58a7bd
Compare
adguernier
approved these changes
Jan 25, 2024
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
question (non-blocking): I'm just wondering why not using the latest versionactions/checkout@v4
There was a problem hiding this comment.
I used the same we already have
slax57
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When working on react-admin, we have our dependencies pinned and we may not see errors that may happen with more recent versions of those dependencies like what happened with react-router.
Solution
Introduce a github action running on new tagged releases that will create a new app using
create-react-adminand run some basic tests on it.Follow #9578