Fix clicking on "Remove all filters" does not close the filter menu #9415
+82
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanMarmelab
changed the base branch from
master
to
autocompletinput-clear-button-over-bulk-actions-toolbar
Base automatically changed from
autocompletinput-clear-button-over-bulk-actions-toolbar
to
master
November 2, 2023 07:00
fzaninotto
requested changes
Nov 2, 2023
fzaninotto
requested changes
Nov 2, 2023
packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Nov 2, 2023
| @@ -593,122 +593,3 @@ export const InsideReferenceArrayInputWithCreationSupport = () => ( | |||
| <Resource name="books" edit={BookEditWithReferenceAndCreationSupport} /> | |||
| </Admin> | |||
| ); | |||
|
|
|||
| const booksDataProvider = fakeRestDataProvider({ | |||
There was a problem hiding this comment.
Isn't this code used for tests on the AutocompleteArrayInput?
Also, linter warnings.
There was a problem hiding this comment.
This data was only used for the test I made in this commit, but this test is now in FisterButton.spec.tsx and works with the FisterButton.stories.tsx
fzaninotto
approved these changes
Nov 3, 2023
slax57
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The "Add Filter" button disappears, since there are no filters, but as soon as you enter a new filter, the "Add Filter" menu immediately appears in the corner of the screen.
Solution
Set state to close on "Remove all filters" click
TODOs
Step to reproduce the bug
Issue
Closes #9412