Add <Form disableInvalidFormNotification> to allow disabling notifications when the form is invalid
#9353
Conversation
tim-pankoke
changed the title
tim-pankoke
changed the title
|
Could you please add documentation and unit tests? |
tim-pankoke
changed the title
tim-pankoke
changed the title
added docs and a test to verify my changes ✌️ |
There was a problem hiding this comment.
Otherwise it should be good. I'll just request @fzaninotto 's review to validate the new prop's name.
In any case, thanks!
| await waitFor(() => { | ||
| const notification = screen.queryByText('ra.message.invalid_form'); | ||
| expect(notification).toBeNull(); | ||
| }); |
There was a problem hiding this comment.
This test passes even without disableInvalidFormNotification.
It is not always easy to check for the absence of something with Jest/RTL. You need to find an event to await for, that proves the form submission is complete, before attempting to check if the notification is there or not. You can try providing a jest.fn() as onSuccess to see if it helps, or try rendering the record and have RTL look for the changed value in the record.
There was a problem hiding this comment.
Thanks for the feedback! 🙏
I updated the unit test so that I'm waiting for the validation message to be shown before checking the absence of the notification.
|
Thanks! |
fzaninotto
changed the title
<Form disableInvalidFormNotification> to allow disabling notifications when the form is invalid
This should close #9350