Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add <SolarLayout> component #9282

Merged
merged 4 commits into from
Sep 18, 2023
Merged

[Doc] Add <SolarLayout> component #9282

merged 4 commits into from
Sep 18, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Sep 15, 2023

image

@@ -534,8 +534,32 @@ If you want to deeply customize the app header, the menu, or the notifications,

React-admin offers predefined layouts for you to use:

<figure>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image maps aren't responsive, so using svg is the only way to make parts of an image clickable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the content to the ContainerLayout chapter as this component cannot live outside it. It's consistent with SolarMenu and SolarAppBar, which are documented in SolarLayout.

The alternative, which is to document them each in one page, makes the "UI Elements" navigation menu way too lengthy.

Individual sections are referenced in the index anyway.

@fzaninotto fzaninotto changed the title [Doc] Add Solarlayout component [Doc] Add <SolarLayout> component Sep 15, 2023
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

docs/ContainerLayout.md Outdated Show resolved Hide resolved
docs/SolarLayout.md Outdated Show resolved Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
@slax57 slax57 added this to the 4.14.2 milestone Sep 18, 2023
@slax57 slax57 merged commit ea1cddb into master Sep 18, 2023
@slax57 slax57 deleted the solarlayout branch September 18, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants