-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add <SolarLayout>
component
#9282
Conversation
fzaninotto
commented
Sep 15, 2023
•
edited
Loading
edited
@@ -534,8 +534,32 @@ If you want to deeply customize the app header, the menu, or the notifications, | |||
|
|||
React-admin offers predefined layouts for you to use: | |||
|
|||
<figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image maps aren't responsive, so using svg is the only way to make parts of an image clickable.
docs/HorizontalMenu.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the content to the ContainerLayout chapter as this component cannot live outside it. It's consistent with SolarMenu and SolarAppBar, which are documented in SolarLayout.
The alternative, which is to document them each in one page, makes the "UI Elements" navigation menu way too lengthy.
Individual sections are referenced in the index anyway.
<SolarLayout>
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>