[SimpleFormIterator] default to null instead of empty string #8787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this PR. |
slax57
reviewed
Apr 3, 2023
There was a problem hiding this comment.
PR seems good to me, thanks! 🙂
However, for the reasons I explain here #8785 (comment) , we would rather keep this for the next minor version (v4.10).
Hence, can you please rebase your PR on top of the next branch instead?
Thanks!
This reverts commit 5e61836.
|
I have done the rebase on the next branch, but comparing it with the next branch I see some extra stuff in the diff. I will open a clean PR with a cherry-pick and close this one. #8792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SimpleFormIteratoractually is defaulting every input inside aFormDataConsumerto an empty string. So if I have some arrays, objects, or numbers inside, they default to the empty strings when I add new elements to the array.I propose to make the default equal to null instead. I know this is a kind of breaking change but I think is more consistent, in case we don't have enough information to determine the right return type null should be better.
This should also solve this issue: #8785 because it will default to null when no default value will be provided.
Let me know what you think about it!