Fix <Appbar> buttons don't have consistent spacing
#8356
Merged
+13
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Nov 4, 2022
|
|
||
| const Root = styled(Box, { | ||
| name: PREFIX, | ||
| overridesResolver: (props, styles) => styles.root, | ||
| })(({ theme }) => ({ | ||
| [`& .${LocalesMenuButtonClasses.selectedLanguage}`]: { |
There was a problem hiding this comment.
This change requires a doc update
| onClick={() => setOpen(!open)} | ||
| size="large" | ||
| > | ||
| <StyledIconButton color="inherit" onClick={() => setOpen(!open)}> |
There was a problem hiding this comment.
#8350 also suggested to pass the ...rest props to the button, don't you think we should do it too?
There was a problem hiding this comment.
#8350 also suggested to pass the
...restprops to the button, don't you think we should do it too?
+1 on this. And in ToggleThemeButton
There was a problem hiding this comment.
I don't see the need for this
WiXSL
suggested changes
Nov 4, 2022
| onClick={() => setOpen(!open)} | ||
| size="large" | ||
| > | ||
| <StyledIconButton color="inherit" onClick={() => setOpen(!open)}> |
There was a problem hiding this comment.
#8350 also suggested to pass the
...restprops to the button, don't you think we should do it too?
+1 on this. And in ToggleThemeButton
WiXSL
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Closes #8347