-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated empty values sanitization #8188
Merged
Merged
+530
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Sep 29, 2022
slax57
requested changes
Sep 29, 2022
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
WiXSL
suggested changes
Sep 29, 2022
Co-authored-by: Aníbal Svarcas <[email protected]>
WiXSL
suggested changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase to include #8162?
We may have to change the note in the docs of AutocompleteInput
and SelectInput
regarding emptyValue
prop being null
slax57
approved these changes
Sep 29, 2022
Back to WIP as this makes #7782 more pregnant |
Back to RFR - we'll fix #7782 in a bug fix release, no need to delay the next minor. |
slax57
requested changes
Sep 30, 2022
slax57
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All form inputs have an empty value of
''
(empty string). React-hook-form doesn't sanitize these values by default. This leads to unexpectedcreate
andupdate
payloads like:The currently documented solution is to use
parse
on individual inputs, and/ortransform
at the controller level.But none of these solutions is particularly convenient when developers have to use them everywhere. The input-level solution is super repetitive, and the controller-one is at the wrong level - the problem is caused by the form, it should be handled by the form.
Solution
Introduce an opt-in
<Form sanitizeEmtyValues>
propTodo
sanitizeEmptyValues in
,
, and
``transform
to sanitize empty values