Fix dataProvider hooks do not handle pageInfo
when updating 'getList' query cache
#8105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The dataProvider hooks
useUpdate
,useUpdateMany
,useDelete
anduseDeleteMany
directly updates the'getList'
result when successful, but they did not handle thepageInfo
. This lead to a pagination bug in EE module ra-editable-datagrid.Bonus problem:
It also appears that the
'getList'
cache was incorrectly populated byuseUpdateMany
, because fed with the list ofids
as data, instead of the record data.This lead to having cached values like:
instead of:
Solution:
pageInfo
correctlyGetListResult
typeuseUpdateMany
now callsupdateCache
with the properdata