Fix<DeleteButton mutationOptions> ignores meta parameter
#8023
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import React from 'react'; | ||
| import expect from 'expect'; | ||
| import { MemoryRouter, Route, Routes } from 'react-router'; | ||
| import { fireEvent, screen, render, waitFor } from '@testing-library/react'; | ||
|
|
||
| import { testDataProvider } from '../../dataProvider'; | ||
| import { CoreAdminContext } from '../../core'; | ||
| import useDeleteWithConfirmController, { | ||
| UseDeleteWithConfirmControllerParams, | ||
| } from './useDeleteWithConfirmController'; | ||
|
|
||
| describe('useDeleteWithConfirmController', () => { | ||
| it('should call the dataProvider.delete() function with the meta param', async () => { | ||
| let receivedMeta = null; | ||
| const dataProvider = testDataProvider({ | ||
| delete: jest.fn((ressource, params) => { | ||
| receivedMeta = params?.meta?.key; | ||
| return Promise.resolve({ data: params?.meta?.key }); | ||
| }), | ||
| }); | ||
|
|
||
| const MockComponent = () => { | ||
| const { handleDelete } = useDeleteWithConfirmController({ | ||
| record: { id: 1 }, | ||
| resource: 'posts', | ||
| mutationMode: 'pessimistic', | ||
| mutationOptions: { meta: { key: 'metadata' } }, | ||
| } as UseDeleteWithConfirmControllerParams); | ||
| return <button onClick={handleDelete}>Delete</button>; | ||
| }; | ||
|
|
||
| render( | ||
| <MemoryRouter> | ||
| <CoreAdminContext dataProvider={dataProvider}> | ||
| <Routes> | ||
| <Route path="/" element={<MockComponent />} /> | ||
| </Routes> | ||
| </CoreAdminContext> | ||
| </MemoryRouter> | ||
| ); | ||
|
|
||
| const button = await screen.findByText('Delete'); | ||
| fireEvent.click(button); | ||
| waitFor(() => expect(receivedMeta).toEqual('metadata'), { | ||
fzaninotto marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| timeout: 1000, | ||
| }); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import React from 'react'; | ||
| import expect from 'expect'; | ||
| import { MemoryRouter, Route, Routes } from 'react-router'; | ||
| import { fireEvent, screen, render, waitFor } from '@testing-library/react'; | ||
|
|
||
| import { testDataProvider } from '../../dataProvider'; | ||
| import { CoreAdminContext } from '../../core'; | ||
| import useDeleteWithUndoController, { | ||
| UseDeleteWithConfirmControllerParams, | ||
| } from './useDeleteWithConfirmController'; | ||
|
|
||
| describe('useDeleteWithUndoController', () => { | ||
| it('should call the dataProvider.delete() function with the meta param', async () => { | ||
| let receivedMeta = null; | ||
| const dataProvider = testDataProvider({ | ||
| delete: jest.fn((ressource, params) => { | ||
| receivedMeta = params?.meta?.key; | ||
| return Promise.resolve({ data: params?.meta?.key }); | ||
| }), | ||
| }); | ||
|
|
||
| const MockComponent = () => { | ||
| const { handleDelete } = useDeleteWithUndoController({ | ||
| record: { id: 1 }, | ||
| resource: 'posts', | ||
| mutationMode: 'undoable', | ||
| mutationOptions: { meta: { key: 'metadata' } }, | ||
| } as UseDeleteWithConfirmControllerParams); | ||
| return <button onClick={handleDelete}>Delete</button>; | ||
| }; | ||
|
|
||
| render( | ||
| <MemoryRouter> | ||
| <CoreAdminContext dataProvider={dataProvider}> | ||
| <Routes> | ||
| <Route path="/" element={<MockComponent />} /> | ||
| </Routes> | ||
| </CoreAdminContext> | ||
| </MemoryRouter> | ||
| ); | ||
|
|
||
| const button = await screen.findByText('Delete'); | ||
| fireEvent.click(button); | ||
| waitFor(() => expect(receivedMeta).toEqual('metadata'), { | ||
| timeout: 1000, | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description isn't entirely accurate, as react-query's
optionscannot contain ametakey. In fact, you should probably add an example explaining how to set themetaparameter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a
metaoption inuseMutation. It is of typeRecord<string, unknown>when ours isanythough.