-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to accept more than one child in <Reference>
Fields
#7812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, that's great! And we can probably do the same with ReferenceManyField too
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Co-authored-by: Gildas Garcia <[email protected]>
Co-authored-by: Gildas Garcia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing though 🙁
It was a GitHub failure. I relaunched the build and it passes. |
Back to WIP to address other reference field components |
back to RFR |
<ReferenceField>
<Reference>
Fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Gildas Garcia <[email protected]>
Problem
Developers often need to render more than one field of the reference table (e.g. if the
users
table has afirst_name
and alast_name
field) in a<ReferenceField>
. And<FunctionField>
is a bit cumbersome.Solution
Let
<ReferenceField>
accept more than one child, so that developers can use as many<Field>
as they like:<ReferenceField>
code, doc and tests<ReferenceManyField>
code, doc and tests<ReferenceOneField>
code, doc and tests<ReferenceArrayField>
code, doc and tests