Fix cannot use theme to override input variant #7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
Fix-theme-override
branch
from
6c577e9 to
d165964
Compare
|
The compilation error seems to come from MUI... mui/material-ui#32659 |
fzaninotto
added
RFR
|
Switching to RFR |
slax57
reviewed
May 9, 2022
| } | ||
| + MuiTextField: { | ||
| + defaultProps: { | ||
| + variant: 'filled', |
There was a problem hiding this comment.
don't we need as const here?
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
djhi
approved these changes
May 9, 2022
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7635
variant,margin,sizein all Input componentsvariant,margin,sizein the default themevariant,margin,sizein the demos themeThis PR introduces a small BC break, but I think we cannot wait the next major for that, plus it's an easy fix.