Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ra-no-code - Introduce ApplicationsDashboard #6221

Merged
merged 4 commits into from
May 7, 2021
Merged

ra-no-code - Introduce ApplicationsDashboard #6221

merged 4 commits into from
May 7, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Apr 28, 2021 •
edited
Loading

  • Implement Dashboard
  • Ensure each app and its data is stored under a unique key
  • Add a menu item in the user menu to go back to the dashboard

ra-no-code-apps

@djhi djhi added the WIP Work In Progress label Apr 28, 2021
@djhi djhi force-pushed the ra-no-code-multiple-apps branch 2 times, most recently from bbc7a7d to 1125f8c Compare April 29, 2021 15:38
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Apr 29, 2021
@djhi djhi requested a review from fzaninotto May 5, 2021 12:57
@fzaninotto fzaninotto changed the base branch from master to next May 6, 2021 13:08
@fzaninotto
Copy link
Member

Needs rebase

fzaninotto
fzaninotto requested changes May 6, 2021
View reviewed changes
packages/ra-no-code/src/ApplicationsDashboard/ApplicationsDashboard.tsx Outdated
);
};

const loadApplicationsFromStorage = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the following method are the "model" of the app storage, and as such I think they should live in a dedicated file

@djhi djhi force-pushed the ra-no-code-multiple-apps branch from 1125f8c to 620b153 Compare May 6, 2021 14:02
@fzaninotto
Copy link
Member

The failing test will disappear if you rebase

@djhi djhi force-pushed the ra-no-code-multiple-apps branch from 620b153 to 89e8233 Compare May 7, 2021 07:17
@fzaninotto fzaninotto merged commit f893eff into next May 7, 2021
@fzaninotto fzaninotto deleted the ra-no-code-multiple-apps branch May 7, 2021 07:41
@fzaninotto fzaninotto added this to the 3.16.0 milestone May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto