ra-no-code - Introduce Resource Configuration #6217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Apr 27, 2021
•
djhi
commented
- Introduce Configuration Screen
- Implement basic resource configuration
- Implement basic field configuration
- Allow to select on which views a field is displayed
djhi
force-pushed
the
ra-no-code-configuration
branch
from
cc880f9 to
41beace
Compare
djhi
force-pushed
the
ra-no-code-configuration
branch
from
a76d5aa to
429825a
Compare
djhi
force-pushed
the
ra-no-code-configuration
branch
from
429825a to
a8b160f
Compare
fzaninotto
requested changes
May 5, 2021
| return ( | ||
| <CardContent> | ||
| <TextInput | ||
| source={`fields[${index}].props.source`} |
There was a problem hiding this comment.
As $index can contain a dot, you should use lodash's get
There was a problem hiding this comment.
I don't get this comment
There was a problem hiding this comment.
It does not because fields is the array of fields in the resource configuration object
There was a problem hiding this comment.
I'll make it clearer though
packages/ra-no-code/src/ResourceConfiguration/FieldConfigurationFormSection.tsx
Outdated
Show resolved
Hide resolved
packages/ra-no-code/src/ResourceConfiguration/FieldConfigurationFormSection.tsx
Outdated
Show resolved
Hide resolved
packages/ra-no-code/src/ResourceConfiguration/ResourceConfiguration.tsx
Outdated
Show resolved
Hide resolved
| .create(resource, { | ||
| data: record, | ||
| }) | ||
| .catch(error => console.error(error)); |
There was a problem hiding this comment.
why did you remove error catching?
There was a problem hiding this comment.
Because I only used it for debug. A proper error catching should be added
There was a problem hiding this comment.
For now I'd rather have the whole thing explode than the error being hidden like before
fzaninotto
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.