[RFR] Convert ResettableTextField component to useStyles #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaytula
changed the title
djhi
requested changes
Aug 26, 2019
fzaninotto
requested changes
Aug 28, 2019
djhi
requested changes
Aug 28, 2019
djhi
approved these changes
Aug 28, 2019
djhi
requested changes
Aug 28, 2019
jaytula
force-pushed
the
usestyles-resettabletextfield
branch
from
76095d5 to
ad2fda5
Compare
|
Sorry, this PR now needs rebase |
jaytula
force-pushed
the
usestyles-resettabletextfield
branch
from
ad2fda5 to
b8c4593
Compare
|
Sure, no problem. I've rebased against |
djhi
requested changes
Sep 2, 2019
|
|
||
| handleMouseDownClearButton = event => { | ||
| const handleMouseDownClearButton = useCallback(event => { |
There was a problem hiding this comment.
If it doesn't use anything from the component itself (such as state or props), you can even declare this function outside of the component and won't need the useCallback at all
There was a problem hiding this comment.
ok, thanks! I've declared it outside the component.
jaytula
force-pushed
the
usestyles-resettabletextfield
branch
from
b8c4593 to
ebbbe04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert ResettableTextField component to useStyles. #3453