[RFR] Add <DateTimeInput> #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
Datetime-input
branch
from
f29a7a9 to
c7fee08
Compare
djhi
approved these changes
Sep 19, 2018
djhi
reviewed
Sep 19, 2018
| @@ -1,9 +1,9 @@ | |||
| import React from 'react'; | |||
| import FormField from './FormField'; | |||
|
|
|||
| export default BaseComponent => { | |||
| export default (BaseComponent, fieldProps = {}) => { | |||
There was a problem hiding this comment.
This should be documented though
djhi
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~~Due to the way
<input type="datetime-local" /> works on Chrome, I had to store a local draft state and couldn't resort to redux-form'sparseandformat` (see commit list).~~~I managed to make it a stateless component thanks to redux-form's
parseandformat.