[Doc] Impove scrollToTop in buttons doc and document _scrollToTop in useRedirect
#10449
+100
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jan 16, 2025
Comment on lines
-38
to
-45
| // redirect to the result of a function | ||
| redirect((resource, id, data) => { | ||
| return data.hasComments ? '/comments' : '/posts'; | ||
| }, 'posts', 1, { hasComments: true }); | ||
| // redirect to edit view with state data | ||
| redirect('edit', 'posts', 1, {}, { record: { post_id: record.id } }); | ||
| // do not redirect (resets the record form) | ||
| redirect(false); |
There was a problem hiding this comment.
To isolate it in their own chapter
Co-authored-by: Francois Zaninotto <[email protected]>
djhi
requested changes
Jan 16, 2025
| ## Redirect function | ||
|
|
||
| `useRedirect` allows you to redirect to the result of a function as follows: |
There was a problem hiding this comment.
This deserves more examples as you can also return an object as expected by useNavigate
Co-authored-by: Gildas Garcia <[email protected]>
fzaninotto
reviewed
Jan 17, 2025
Co-authored-by: Francois Zaninotto <[email protected]>
fzaninotto
reviewed
Jan 17, 2025
djhi
requested changes
Jan 20, 2025
djhi
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
scrollToTopwith the Algolia search_scrollToTopinuseRedirect's docAdditional Checks
masterfor a bugfix, ornextfor a feature