-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TextArrayInput to edit arrays of strings #10384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Dec 3, 2024
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Review applied |
slax57
reviewed
Dec 5, 2024
slax57
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our various array input components don't support the simple case of editing an array of strings with no choices.
Solution
2 possibilities:
AutocompleteArrayInput
to support simple addition withfreeSolo
. This is not possible because this input heavily relies on suggestions, and can't take a value outside of its choices. Even theonCreate
support uses a special choice.<Autocomplete>
component.I tried 1. but failed, so I went for 2.
DX
TextArrayInput.mp4
How To Test
Launch the storybook and check out the
ra-ui-materialui/inputs/TextArrayInput stories
at http://localhost:9010/?path=/story/ra-ui-materialui-input-textarrayinput--basic.To Do