Fix FilterButton checked status #10191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem In the new design of the FilterButton dropdown, the checkbox for a filter is checked is the filter has a value. This isn't intuitive: if a user clicks on the item to have a filter input appear, they expect the checkbox to be displayed next time they open the dropdown. ## Solution Check the checkbox if the filter is displayed, not applied.
djhi
requested changes
Sep 10, 2024
| }} | ||
| filter={filterElement} | ||
| displayed={ | ||
| !!displayedFilters[filterElement.props.source] |
There was a problem hiding this comment.
appliedFilters is not needed anymore, right?
djhi
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the new design of the FilterButton dropdown, the checkbox for a filter is checked is the filter has a value. This isn't intuitive: if a user clicks on the item to have a filter input appear, they expect the checkbox to be displayed next time they open the dropdown.
Solution
Check the checkbox if the filter is displayed, not applied.