Add global Reset CSS #10164
Merged
Add global Reset CSS #10164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Aug 27, 2024
| @@ -1,7 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import { createElement, ComponentType } from 'react'; | |||
| import { CoreAdminUI, CoreAdminUIProps } from 'ra-core'; | |||
| import { ScopedCssBaseline } from '@mui/material'; | |||
There was a problem hiding this comment.
This is the only code change of this PR
slax57
requested changes
Aug 28, 2024
slax57
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For new apps, developers need to reset the body margin manually, unless they use
create-react-admin. This is cumbersome and, in many cases, leads to ugly admins because users have missed one step in the setup.Solution
Use MUI's
CssBaselineinstead ofScopedCssBaseline.This might be a breaking change in some very particular situations where react-admin is included in a div and some other content is rendered ion the same page.
How to test
Compile the
create-react-adminpackage and use it to create a new app. Run the app. If should have correct margins.Additional Checks
masterfor a bugfix, ornextfor a feature[ ] The PR includes unit tests(only design)[ ] The PR includes one or several stories(existing FullApp stories still work)Also, please make sure to read the contributing guidelines.