Skip to content

Commit

Permalink
Merge pull request #8176 from marmelab/fix-confirm-props
Browse files Browse the repository at this point in the history
Fix pass `Confirm` props to the underlying MUI `Dialog` component
  • Loading branch information
fzaninotto authored Sep 16, 2022
2 parents d1b63eb + cbe9518 commit 80d52e4
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions packages/ra-ui-materialui/src/layout/Confirm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import { styled } from '@mui/material/styles';
import { useCallback, MouseEventHandler } from 'react';
import PropTypes, { ReactComponentLike } from 'prop-types';
import Dialog from '@mui/material/Dialog';
import Dialog, { DialogProps } from '@mui/material/Dialog';
import DialogActions from '@mui/material/DialogActions';
import DialogContent from '@mui/material/DialogContent';
import DialogContentText from '@mui/material/DialogContentText';
Expand All @@ -13,7 +13,6 @@ import ActionCheck from '@mui/icons-material/CheckCircle';
import AlertError from '@mui/icons-material/ErrorOutline';
import clsx from 'clsx';
import { useTranslate } from 'ra-core';
import { SxProps } from '@mui/system';

/**
* Confirmation dialog
Expand Down Expand Up @@ -47,7 +46,7 @@ export const Confirm = (props: ConfirmProps) => {
onClose,
onConfirm,
translateOptions = {},
sx,
...rest
} = props;

const translate = useTranslate();
Expand All @@ -71,7 +70,7 @@ export const Confirm = (props: ConfirmProps) => {
onClose={onClose}
onClick={handleClick}
aria-labelledby="alert-dialog-title"
sx={sx}
{...rest}
>
<DialogTitle id="alert-dialog-title">
{translate(title, { _: title, ...translateOptions })}
Expand Down Expand Up @@ -112,7 +111,7 @@ export const Confirm = (props: ConfirmProps) => {
);
};

export interface ConfirmProps {
export interface ConfirmProps extends Omit<DialogProps, 'open' | 'onClose'> {
cancel?: string;
className?: string;
confirm?: string;
Expand All @@ -126,7 +125,6 @@ export interface ConfirmProps {
onConfirm: MouseEventHandler;
title: string;
translateOptions?: object;
sx?: SxProps;
}

Confirm.propTypes = {
Expand Down

0 comments on commit 80d52e4

Please sign in to comment.