Reload export data when list is (re)filtered #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exportToCsv function was failing to correctly (re)load data in a new filtered page. This was due to an incorrect search parameters given to the ReadQueries getAll function. Using $stateParams' search attribute (instead of scope.search()) solves the issue.
| @@ -4,8 +4,7 @@ export default function maExportToCsvButton ($stateParams, Papa, notification, A | |||
| scope: { | |||
| entity: '&', | |||
| label: '@', | |||
| datastore: '&', | |||
| search: '&' | |||
There was a problem hiding this comment.
You'll have to remove the search param where the directive is called, in listLayout.thml
|
You are right, forgot to push it. It is fixed now. |
fzaninotto
added a commit
that referenced
this pull request
Dec 10, 2015
Reload export data when list is (re)filtered
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportToCsv function was failing to correctly reload data in a new filtered page. This was due to an incorrect search parameters given to the ReadQueries getAll function. Using $stateParams' search
attribute (instead of scope.search()) solves the issue.
Fix ng-admin issue #738.