[BC BREAK] [RFR] Rename main view to ng-admin #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
named_view
branch
from
cbd0341
to
efa2374
Compare
jpetitcolas
reviewed
Sep 19, 2016
| return Configuration().layout() || layoutTemplate; | ||
| }] | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| $stateProvider.state('dashboard', { |
There was a problem hiding this comment.
Note that we can also use dotted notation for parent views: ng-admin.dashboard for instance.
beevelop
added a commit
to beevelop/ng-admin-jwt-auth
that referenced
this pull request
Jan 22, 2017
marmelab/ng-admin#759 renamed the main view to `ng-admin` This breaks ng-admin JWT-Auth with the latest ng-admin versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we can configure the view name, since the routing executes before we can access the configuration...
Closes #335, #446, #730