Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] All fields have template #713

Merged
merged 15 commits into from
Oct 1, 2015
Merged

Conversation

fzaninotto
Copy link
Member

Now all field types have a .template() method - so the need to create a custom type becomes quite rare.

  • make it work
  • add tests
  • add doc

In the process of clarifying which variables are available for templates in all situations, I added value everywhere, and it simplifies fieldViews a lot.

@fzaninotto fzaninotto changed the title [WIP] All fields have template [RFR] All fields have template Oct 1, 2015
@fzaninotto
Copy link
Member Author

Switching to RFR

@fzaninotto
Copy link
Member Author

Back to WIP, there are bugs.

@fzaninotto fzaninotto changed the title [RFR] All fields have template [WIP] All fields have template Oct 1, 2015
@fzaninotto fzaninotto changed the title [WIP] All fields have template [RFR] All fields have template Oct 1, 2015
@fzaninotto
Copy link
Member Author

And we're back to Ready For Review!


## All fields have `.template()`

All field types now support the `template()` method, which makes it easy to customize the look and feel of a particular field, withut sacrificing the native features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without

@@ -32,9 +32,31 @@ myEntity.listView().fields([
]);
```

## Customizing The Template For A Given Field

All field types support the `template()` method, which makes it easy to customize the look and feel of a particular field, withut sacrificing the native features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without

jpetitcolas added a commit that referenced this pull request Oct 1, 2015
@jpetitcolas jpetitcolas merged commit 4298be8 into master Oct 1, 2015
@jpetitcolas jpetitcolas deleted the all_fields_have_template branch October 1, 2015 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants