[RFR] Preload references in refrenced_list entries #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call for unoptimized then optimized data is moved to ReadQuery
fzaninotto
changed the title
|
Switching to RFR |
| const identifierName = scope.targetEntity.identifier().name() | ||
| scope.referencedEntry = scope.datastore() | ||
| .getEntries(scope.targetEntity.uniqueId + '_values') | ||
| .filter(entry => entry.values[identifierName] == value) |
There was a problem hiding this comment.
Assuming that the APIs we fetch are consistent (i.e. that the type of comment.post_id is the same as the type of post.id) is pretty brave, but I think we'd rather be tolerant to ease compatibility. So e.g. when comment.post_id is '1' and post.id is 1, the current code works.
|
👍 |
fzaninotto
added a commit
that referenced
this pull request
Sep 17, 2015
[RFR] Preload references in refrenced_list entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #637, #383