[RFR] Use UI-Select for Choice and Choices fields #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Promising! |
| **Tip:** if you are working on Karma tests, you can prevent from relaunching the whole process by disabling single-run: | ||
|
|
||
| ``` | ||
| KARMA_SINGLE_RUN=false grunt karma:unit |
There was a problem hiding this comment.
Special focus on this line. May save a lot of time!
There was a problem hiding this comment.
It has already been changed. This is not native to Karma, this is specific to ng-admin. See Gruntfile changes.
|
Miss a last point on this PR: |
jpetitcolas
changed the title
|
Back to WIP: multiple choices required constraint is not taken into account. |
| scope.v = field.validation(); | ||
|
|
||
| var template = ` | ||
| <ui-select ${scope.v.required ? 'ui-select-required' : ''} multiple ng-model="$parent.value" ng-required="v.required" id="{{ name }}" name="{{ name }}"> |
There was a problem hiding this comment.
Not proud of this, but ng-attr-ui-select-required did not work.
|
Back to RFR. |
ThieryMichel
added a commit
that referenced
this pull request
Jun 15, 2015
[RFR] Use UI-Select for Choice and Choices fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds select filtering and a better UI for multi-selects.
Before:
Now:
It will especially be useful to populate live select lists using AJAX requests.
Tasks: