[RFR] Refactor datagrid pagination #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(totalElement.innerText.trim()).toBe('No record found.'); | ||
| }); | ||
|
|
||
| it('should display item range displayed', function() { |
There was a problem hiding this comment.
Review description label
There was a problem hiding this comment.
"it should display the content range currently displayed"
|
Missing:
|
| scope.infinite = true; | ||
| }); | ||
|
|
||
| it('should not be displayed if pagination is infinite', function() { |
There was a problem hiding this comment.
Well, that's a problem in fact. It's not related with this PR, but infinite pagination hides the total number of results. We need to solve this in the UI.
|
Any progress? |
fzaninotto
force-pushed
the
pagination_test
branch
from
160c8b3
to
33f2d9d
Compare
* Limit buttons in case of large content range (closes #296) * Add link to first and last page * Use default Bootstrap markup for pagination
fzaninotto
force-pushed
the
pagination_test
branch
from
729c9ff
to
0653e4c
Compare
fzaninotto
changed the title
|
Switching to RFR |
| @@ -1,12 +0,0 @@ | |||
| <div ng-if="!paginationCtrl.infinite"> | |||
There was a problem hiding this comment.
renamed to maDatagridPagination
jpetitcolas
added a commit
that referenced
this pull request
Mar 2, 2015
[RFR] Refactor datagrid pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how the pagination nav looks for a 9 page list: