-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Angular 1.6 #1297
Merged
Merged
[RFR] Angular 1.6 #1297
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
57b93dc
Nicer test reporters
Kmaschta 4544128
Angular 1.5
Kmaschta 452712a
Angular 1.6
Kmaschta 4494ecf
Code review
Kmaschta 5fdc5bb
Update 1.0 documentation
Kmaschta bcdc0a8
Typo fix s/There/Here/
sedy-bot f320c13
Typo fix s/Ng/ng/
sedy-bot 0d1258f
Typo fix s/on/in/
sedy-bot 5fa1d90
Typo fix s/no longer support/doesn't support/
sedy-bot 40a9be7
Typo fix s/- //
sedy-bot 98d7102
Code review
Kmaschta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
const location = ($locationProvider) => { | ||
// Keep the start of all routes to #/ instead of #!/ | ||
// while updating to Angular 1.6 | ||
// @see https://docs.angularjs.org/guide/migration#commit-aa077e8 | ||
$locationProvider.hashPrefix(''); | ||
}; | ||
|
||
location.$inject = ['$locationProvider']; | ||
|
||
export default location; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align angular-mocks version with this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!