-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Display progress bar when deleting #1140
Conversation
It would be great to test that |
👍 |
return this.WriteQueries.deleteOne(this.view, this.entityId) | ||
.then(() => this.previousStateParametersDeferred.promise) | ||
.then(previousStateParameters => { | ||
// if previous page was related to deleted entity, redirect to list | ||
if (previousStateParameters.entity === entityName && previousStateParameters.id === this.entityId) { | ||
this.$state.go(this.$state.get('list'), angular.extend({ | ||
return this.$state.go(this.$state.get('list'), angular.extend({ | ||
entity: entityName | ||
}, this.$state.params)); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need an else
statement here
@jpetitcolas this can only be done in an e2e test (because the It is left as an exercise for the reader. |
review applied |
Thanks @fzaninotto for contributing to marmelab open-source projects! |
Closes #1109