Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reference to 'notification' service #1028

Merged
merged 1 commit into from
May 17, 2016
Merged

Fixed reference to 'notification' service #1028

merged 1 commit into from
May 17, 2016

Conversation

ganlhi
Copy link

@ganlhi ganlhi commented Apr 12, 2016

There was a missing 'this' keyword using the notification service in one of the FormController methods.

@fzaninotto
Copy link
Member

Thanks. But can you remove the built files from your PR? I'll update them myself.

@ganlhi
Copy link
Author

ganlhi commented Apr 15, 2016

Hi, I just removed the build commit from the branch.

@ganlhi ganlhi closed this Apr 15, 2016
@ganlhi ganlhi reopened this Apr 15, 2016
@Orlicek Orlicek mentioned this pull request May 9, 2016
Closed
@fzaninotto fzaninotto merged commit a984116 into marmelab:master May 17, 2016
@marmelab-bot
Copy link
Contributor

Thanks @ganlhi for contributing to marmelab open-source projects!
As a sign of our gratitude, you can publish an image to advertise your brand on the marmelab website for a whole day.
Head to this page to submit your image. It will appear on Zero Dollar Homepage, powered by blockchain technology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganlhi @fzaninotto @marmelab-bot @guilhembrouat