Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong endings for ordinal numbers from 11 to 13 #7

Closed
pilyugin opened this issue Feb 12, 2016 · 1 comment
Closed

Wrong endings for ordinal numbers from 11 to 13 #7

pilyugin opened this issue Feb 12, 2016 · 1 comment

Comments

@pilyugin
Copy link

Converter returns ordinal numbers with wrong endings:

converter.toOrdinal(11); // => “11st”
converter.toOrdinal(12); // => “12nd”
converter.toOrdinal(13); // => “13rd”

But should be 11th, 12th, 13th.
@pilyugin pilyugin changed the title Wrong ending for ordinal from 11 to 13 Wrong endings for ordinal numbers from 11 to 13 Feb 12, 2016
pilyugin added a commit to pilyugin/number-to-words that referenced this issue Feb 12, 2016
@pilyugin
toOrdinal: added special behavior for numbers ending with 11, 12 and …
eb196e4 
…13. Fixes marlun78#7
@pilyugin pilyugin mentioned this issue Feb 12, 2016
Merged
@pilyugin
Copy link
Author

Please see my PR #8 which fixes this bug.

marlun78 added a commit that referenced this issue Feb 12, 2016
@marlun78
Merge pull request #8 from pilyugin/master
5e5e45f 
toOrdinal: added special behavior for numbers ending with 11, 12 and 13. Fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pilyugin