updated upgradepackage and unit_test workflow as an example of end to end ftd upgrade #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2024 13:26
…_post bug, added additional code to unit test for examples of how to do an entire upgrade start to finish, fixed a broken import for wait_for_task
…quest to be the entire response so it can be piped into wait_for_task. This doesn't seem to break anything else in the library but could break code in the wild, but I believe returning the full response from a deployment request to be worth the cost
|
I have used this to upgrade standalone FTDs and HA FTDs. I still have to confirm that the example upgrade code works with multiple standalone devices at one time. Hoping to get a window to run it against the remaining devices I need to upgrade in our environment. |
marksull
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated upgradepackage to include the ability to trigger readiness checks and other newer flags in that api endpoint (based on fmc 7.4.1.1)
upgrade unit_test workflow now has an example of end to end ftd upgrade (push file, readiness check, upgrade, post upgrade deployment)
fmcapi/api_objects/deployment_services/deploymentrequests.pywas modified and may break some code in the wild with this modification.Instead of returning just the device list in the deployment response, it made more sense to me to return the entire response and then pull the device list out outside of the object code. This also means that deploymentrequest now works and fits better with the existing
wait_for_taskunit_test