Description added to objects & Remove port from required protocolport…

…object By removing port from required_for_post for protocolportobject allows creation of non tcp/udp objects (poor naming by cisco api?) Added descriptions to valid json data (requested by more than one of my clients)
marksull · Oct 1, 2023 · c90431f · c90431f
1 parent afe5fbe
commit c90431f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/fmcapi/api_objects/object_services/fqdns.py b/fmcapi/api_objects/object_services/fqdns.py
@@ -10,6 +10,7 @@ class FQDNS(APIClassTemplate):
     VALID_JSON_DATA = [
         "id",
         "name",
+        'description',
         "type",
         "overridableTargetId",
         "value",

diff --git a/fmcapi/api_objects/object_services/icmpv4objects.py b/fmcapi/api_objects/object_services/icmpv4objects.py
@@ -10,6 +10,7 @@ class ICMPv4Objects(APIClassTemplate):
     VALID_JSON_DATA = [
         "id",
         "name",
+        "description",
         "type",
         "overrideTargetId",
         "code",

diff --git a/fmcapi/api_objects/object_services/protocolportobjects.py b/fmcapi/api_objects/object_services/protocolportobjects.py
@@ -10,7 +10,7 @@ class ProtocolPortObjects(APIClassTemplate):
     VALID_JSON_DATA = ["id", "name", "description", "port", "protocol", "type"]
     VALID_FOR_KWARGS = VALID_JSON_DATA + []
     URL_SUFFIX = "/object/protocolportobjects"
-    REQUIRED_FOR_POST = ["name", "port", "protocol"]
+    REQUIRED_FOR_POST = ["name",  "protocol"]
 
     def __init__(self, fmc, **kwargs):
         """
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,7 @@ class ICMPv4Objects(APIClassTemplate): @@
         VALID_JSON_DATA = [
             "id",
             "name",
+            "description",
             "type",
             "overrideTargetId",
             "code",
@@ Expand Down @@