Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV-196: Remove duplicated Charset #13

Merged
merged 1 commit into from
Nov 19, 2024
Merged

CSV-196: Remove duplicated Charset #13

merged 1 commit into from
Nov 19, 2024

Conversation

DarrenJAN
Copy link

  • Remove Charset since it is already in the parent class
  • Call getCharset() instead

@DarrenJAN
Copy link
Author

run mvn
image

yunzvanessa
yunzvanessa approved these changes Nov 19, 2024
View reviewed changes
Copy link

@yunzvanessa yunzvanessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yuzhan,

The code change looks good. Please change the PR title to "CSV-196: Remove duplicated charset" something like this

@DarrenJAN DarrenJAN changed the title Fix Charset CSV-196: Remove duplicated Charset Nov 19, 2024
@DarrenJAN DarrenJAN merged commit 344f282 into marklogic:CSV-196-master Nov 19, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunzvanessa yunzvanessa yunzvanessa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarrenJAN @yunzvanessa