Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

change default logo from "MarkLogic" to "Powered by MarkLogic" #434

Closed
patrickmcelwee opened this issue Dec 20, 2016 · 6 comments
Closed
Assignees
Milestone

Comments

@patrickmcelwee
Copy link
Contributor

Feedback from my SEs (specifically Scott Fowler) is that whenever the "MarkLogic" logo is in the top left, recipients of a demo presentation often get confused, thinking that the demo is an official front-end to MarkLogic. "Powered by MarkLogic" could help make that more clear.

I know that we typically replace that logo, but do people agree that replacing the default would be helpful?

@jenbreese
Copy link
Contributor

jenbreese commented Dec 20, 2016

We can remove/replace that top logo with a plain <h1>Your Application title here</h1>. I don't think we need a dummy logo to replace the ML one since we might have the same issue. We already have the powered by logo in the footer. It would look funny up in the header as it is intended as a footer type image.

@patrickmcelwee
Copy link
Contributor Author

Or maybe just "Sample Application", since that's what we have on the default search page (I think)

@jenbreese
Copy link
Contributor

Oh yes, that is what it was. Do other people feel this way as well or is it only one person?

@patrickmcelwee
Copy link
Contributor Author

I've only heard this from one person

@grtjn
Copy link
Contributor

grtjn commented Jan 23, 2017

I wouldn't mind replacing the top-left logo with something along the lines of "Sample Application". Could we do something with @App-Name? Feel free to open a PR against the cards-theme branch. If you do, I might include it in 1.3.0.. :)

@grtjn
Copy link
Contributor

grtjn commented Aug 29, 2017

I often find myself just trading out the logo image with a different one. I like having stub code in place for showing a logo. We could add some comments or docs that tell how to hide the logo to show app-name instead?

I do see the point of having generic demos that carry the ML logo at the top instead of the PoweredByML logo. We should probably edit those, but that is out of scope of this project. Then again, in this respect replacing the ML logo with the poweredby one, at the top I mean, does make sense..

@grtjn grtjn added this to the 1.4.0 milestone Aug 29, 2017
@grtjn grtjn self-assigned this Dec 4, 2017
@grtjn grtjn removed the help wanted label Dec 4, 2017
@grtjn grtjn closed this as completed in 9fa153b Dec 4, 2017
grtjn added a commit that referenced this issue Dec 4, 2017
Fixed #434: replaced ML-logo with powered-by-ML logo in header
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants