Issue #37 and Issue #28 #287
Conversation
| @@ -320,6 +314,7 @@ declare function setup:do-setup($import-config as element(configuration)) as ite | |||
| setup:create-amps($import-config), | |||
| setup:apply-database-settings($import-config), | |||
| setup:configure-databases($import-config), | |||
| setup:create-groups($import-config), | |||
There was a problem hiding this comment.
Should this be a bit earlier? You're creating groups after creating forests, but setup:create-forests-from-count(), you're calling admin:group-get-host-ids(). I'd think that if you're creating a group and putting forests in it, that will fail.
There was a problem hiding this comment.
Good catch. It should be earlier.
|
After talking to Dave Cassel we agreed for me to create a follow on ticket #289 to handle any errors that occur from wiping groups. Wiping will likely fail in a cluster since we are not removing hosts before we delete the group. |
|
I would not expect a group attribute to create/remove anything, actually, just attach/unattach where used. To create/wipe groups, i'd recommend using a group element in the config, empty and referred from elsewhere, or containing settings/servers part of that group.. |
adding support for specifying groups for appservers and forests