Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an easier way to extend ModuleExecutor and customize handling of ResultSequence #32

Closed
hansenmc opened this issue Jul 26, 2016 · 0 comments
Closed

Provide an easier way to extend ModuleExecutor and customize handling of ResultSequence #32

hansenmc opened this issue Jul 26, 2016 · 0 comments
Assignees
@hansenmc
Labels
enhancement

Comments

@hansenmc
Copy link
Member

The current implementation has a private writeToFile() method invoked from the public run() method. If someone wanted to extend the ModuleExecutor and customize the handling of the ResultSequence, they would need to re-implement the entire run() method.

It would be easier/better to expose a method, such as processResultSequence(ResultSequence seq) that an extending class could override, rather than duplicating the implementation of the run() method.
@hansenmc hansenmc self-assigned this Jul 26, 2016
hansenmc added a commit that referenced this issue Jul 27, 2016
@hansenmc
resolves issue #32
0845468 
CHANGED: visibility of writeToFile()
ADDED: processResult()
ADDED finally block to ensure that the session and resultSequence are
closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansenmc hansenmc

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hansenmc