Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Variables From Selector Not Being Passed #29

Closed
mpheckel opened this issue Jul 8, 2016 · 2 comments
Closed

Custom Variables From Selector Not Being Passed #29

mpheckel opened this issue Jul 8, 2016 · 2 comments
Assignees
@hansenmc

Comments

@mpheckel
Copy link
Contributor

mpheckel commented Jul 8, 2016

I was trying to pass dynamically created custom vars from the selector but received an error on the transform side. I was able to get them working but only after I had changed the name of the variables. Originally, the variables had hyphens in them as in URIS-MODULE.my-custom-var="blah". It was only after removing the hyphens that it worked: URIS-MODULE.myCustomVar="blah". I'm not sure if underscores work either..

Request that either they be allowed to be used or the readME be updated to alert users of the limitation. They are very handy, thanks!
@hansenmc
Copy link
Member

hansenmc commented Jul 8, 2016

@mpheckel The regex pattern is currently only matching alpha numeric values for the property name. https://github.com/marklogic/corb2/blob/master/src/main/java/com/marklogic/developer/corb/QueryUrisLoader.java#L56

We should support dash - and underscore _.

@hansenmc hansenmc self-assigned this Jul 8, 2016
hansenmc added a commit that referenced this issue Jul 8, 2016
@hansenmc
added support for "-" and "_" in custom variable
3373427 
Adjusted the regex pattern matching custom inputs in the
QueryUrisLoader to include dash and underscore instead of only alpha
numeric properties names. This resolves issue #29
@hansenmc
Copy link
Member

hansenmc commented Jul 8, 2016

@mpheckel I have adjusted the regex pattern to include "-" and "_" and pushed to the development branch. It will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansenmc hansenmc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hansenmc @mpheckel