-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes restore script AWS configuration #31
base: master
Are you sure you want to change the base?
Conversation
97b7abe
to
5beb92b
Compare
This change removes environmental inference from the restore script, restoring the usual credential precedence established in `aws-sdk`. The default region (Sydney) is preserved for back-compatibility.
5beb92b
to
5cbd4c1
Compare
@dylanlingelbach, any thoughts on this? Happy to address any suggestions (or concerns) stemming from the change. |
@rjz sorry for the delay - this looks good to me. |
Although I seem to have lost my write access to this repo. I'll figure out what is going on and get this merged. |
Thanks, @dylanlingelbach! Much appreciated. |
Bump on this PR. Restore won't work on Lambda without this fix. |
LGTM |
@dylanlingelbach, any word on this? Or any leads on who in |
@rjz sorry, no updates yet. I've been slammed at work the past few weeks. Will follow up and let you know. Worst case I will fork to my personal repo and move the npm package there |
@dylanlingelbach any updates on this or other PRs being merged? |
@rafaelmagu still working on regaining write access. Sorry for the delay |
Hey guys,
Can some one guide me to what is the the credential precedence for node sdk |
@dylanlingelbach I guess its mostly talking about the ways in which you can load the credentials but not the order in which node SDK will work / prefer to work. |
This change removes environmental inference from the restore script, restoring the usual credential precedence established in
aws-sdk
. The default region (Sydney) is preserved for back-compatibility.Thanks for your consideration!