Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #62. Simple way to specify dependency options #85

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

foundry-markf
Copy link
Contributor

@foundry-markf foundry-markf commented Jul 13, 2023

Configuration has a new QLineEdit that takes a string of the form

<pkg>:<option>=<value>[,<repeat>]

so that option values for dependencies can be incorporated into the build.

The QLineEdit has a validator to ensure the format.

Conan commands that take options, as well as the lockfile generation as part of recipe loading, will automatically use additional options.

This is a (hopefully) short term solution as 'full options' are not yet expressed as part of the UI.

Configuration has a new QLineEdit that takes a string of the form

<pkg>:<option>=<value>[,<repeat>]

so that option values for dependencies can be incorporated into the build.

The QLineEdit has a validator to ensure the format.

Conan commands that take options, as well as the lockfile generation as part
of recipe loading, will automatically use additional options.

This is a (hopefully) short term solution as 'full options' are not yet
expressed as part of the UI.
@markfinal markfinal self-requested a review July 13, 2023 14:44
@markfinal markfinal added the enhancement New feature or request label Jul 13, 2023
@markfinal markfinal added this to the v1.4.0 milestone Jul 13, 2023
@markfinal markfinal self-assigned this Jul 13, 2023
Copy link
Owner

@markfinal markfinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification to the comment needed

cruiz/recipe/recipewidget.py Outdated Show resolved Hide resolved
Copy link
Owner

@markfinal markfinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markfinal markfinal merged commit 6425a45 into markfinal:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants