Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12 Parse recipe default_options written as a tuple or list #16

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fixes #12 Parse recipe default_options written as a tuple or list #16

merged 1 commit into from
Dec 9, 2022

Conversation

markfinal
Copy link
Owner

  • Modern Conan recipes will use a dict for this attribute, as per the documentation
  • But Conan does parse lists and tuples. This is less type safe.
  • Added some type conversions for bools when written in a tuple/list.

@markfinal
Fixes #12 Parse recipe default_options written as a tuple or list
a82d5d0 
- Modern Conan recipes will use a dict for this attribute, as per the documentation
- But Conan does parse lists and tuples. This is less type safe.
- Added some type conversions for bools when written in a tuple/list.
@markfinal markfinal added the bug Something isn't working label Dec 9, 2022
@markfinal markfinal added this to the v1.3.2 milestone Dec 9, 2022
@markfinal markfinal self-assigned this Dec 9, 2022
@markfinal markfinal merged commit c709934 into v1.3 Dec 9, 2022
@markfinal markfinal deleted the mf/default_options_as_tuple branch December 9, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markfinal markfinal

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging this pull request may close these issues.
1 participant
@markfinal