Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting techdebt #98

Closed
markfinal opened this issue Jul 15, 2023 · 0 comments
Closed

Linting techdebt #98

markfinal opened this issue Jul 15, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@markfinal
Copy link
Owner

Some techdebt in the linting (flake8/mypy) had been deferred until PySide 6 caught up.

Try it again.

@markfinal markfinal added the enhancement New feature or request label Jul 15, 2023
@markfinal markfinal added this to the v1.4.0 milestone Jul 15, 2023
@markfinal markfinal self-assigned this Jul 15, 2023
markfinal added a commit that referenced this issue Jul 15, 2023
- removes a commented out streaming class that I thought I could use, but never did
- fixes some logic errors
- in _get_options_from_recipe, the logic has changed when iterating over possible option values. As I recall it used to work, but the if...else ordering would never have been executed, so mypy is right
markfinal added a commit that referenced this issue Jul 15, 2023
- resource generation occurs as the very first thing when cruiz starts now
- this avoids needing any graphical resources on CI machines
markfinal added a commit that referenced this issue Jul 15, 2023
- removes a commented out streaming class that I thought I could use, but never did
- fixes some logic errors
- in _get_options_from_recipe, the logic has changed when iterating over possible option values. As I recall it used to work, but the if...else ordering would never have been executed, so mypy is right
markfinal added a commit that referenced this issue Jul 15, 2023
- resource generation occurs as the very first thing when cruiz starts now
- this avoids needing any graphical resources on CI machines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant