-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting techdebt #98
Comments
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
- removes a commented out streaming class that I thought I could use, but never did - fixes some logic errors - in _get_options_from_recipe, the logic has changed when iterating over possible option values. As I recall it used to work, but the if...else ordering would never have been executed, so mypy is right
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
- resource generation occurs as the very first thing when cruiz starts now - this avoids needing any graphical resources on CI machines
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
- removes a commented out streaming class that I thought I could use, but never did - fixes some logic errors - in _get_options_from_recipe, the logic has changed when iterating over possible option values. As I recall it used to work, but the if...else ordering would never have been executed, so mypy is right
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
- resource generation occurs as the very first thing when cruiz starts now - this avoids needing any graphical resources on CI machines
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
markfinal
added a commit
that referenced
this issue
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some techdebt in the linting (flake8/mypy) had been deferred until PySide 6 caught up.
Try it again.
The text was updated successfully, but these errors were encountered: