Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options with [None, "ANY"] do not recognize the None as a default #22

Closed
markfinal opened this issue Dec 9, 2022 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@markfinal
Copy link
Owner

markfinal commented Dec 9, 2022

As per https://docs.conan.io/en/1.53/reference/conanfile/attributes.html#options

When an option uses "ANY", but its default value is None, then it should be added to the possible option values too.

the dock does not recognise None being the default so

  1. it does not render initially correctly
  2. setting it to None is treated as a non-default value in the settings, so passed to command lines unnecessarily

An empty string does seem to work in place of None, but is it obvious?

@markfinal markfinal added the bug Something isn't working label Dec 9, 2022
@markfinal markfinal added this to the v1.3.2 milestone Dec 9, 2022
@markfinal markfinal self-assigned this Dec 9, 2022
markfinal added a commit that referenced this issue Dec 9, 2022
- Now renders as 'None (default)' for consistency with combobox options when selected
- Can get back to the default value by writing None or an empty string
markfinal added a commit that referenced this issue Dec 9, 2022
- When default_value=None, now renders as 'None (default)' for consistency with combobox options when selected
- Can get back to the default value by writing the default value or clearing the line edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant